Fix thread-loader memory leaks and worker and main process lifecycles#51
Merged
alexander-akait merged 5 commits intowebpack:masterfrom Dec 19, 2018
Merged
Fix thread-loader memory leaks and worker and main process lifecycles#51alexander-akait merged 5 commits intowebpack:masterfrom
alexander-akait merged 5 commits intowebpack:masterfrom
Conversation
…oader worker and main process lifecycle.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 17.26% 16.98% -0.28%
==========================================
Files 7 7
Lines 365 424 +59
Branches 60 71 +11
==========================================
+ Hits 63 72 +9
- Misses 268 309 +41
- Partials 34 43 +9
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Dec 19, 2018
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good work, will be great increase coverage to 80-90%, but we can do it in other PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is very important and should be merged and released as a patch as soon as possible.
It basically fixes a memory leak introduced by #42 and also fixes the lifecycle both for the worker and for the main process from
thread-loader. With those changes we should be able to get away with every issue related with getting thethread-loader hangingor outputtingbroken pipeerrors directly into the shell stdout after running.The tests were also updated.
CC\ @evilebottnawi